Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.13.0 #1121

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Version 0.13.0 #1121

wants to merge 3 commits into from
+11 −11

Conversation

fingolfin
Copy link
Member

Resolves #1114

@lgoettgens
Copy link
Member

Do you wanna fix #1114 (comment) first?

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.66%. Comparing base (dff38af) to head (31c7819).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files          55       55           
  Lines        4713     4713           
=======================================
  Hits         3519     3519           
  Misses       1194     1194
Files with missing lines Coverage Δ
gap/systemfile.g 100.00% <100.00%> (ø)
pkg/JuliaExperimental/PackageInfo.g 100.00% <100.00%> (ø)
pkg/JuliaInterface/PackageInfo.g 90.26% <100.00%> (ø)

ThomasBreuer
ThomasBreuer reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused.
The description says that #1114 gets resolved, but #1114 describes some (new?) issue?

@lgoettgens
Copy link
Member

I am confused. The description says that #1114 gets resolved, but #1114 describes some (new?) issue?

#1114 is the issue "release 0.13", and in a comment there I posted the errors that the Oscar CI has with the current GAP.jl master. If you click on the link, you get redirected to the stack trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer left review comments

@lgoettgens lgoettgens Awaiting requested review from lgoettgens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Releasing GAP.jl 0.13.0
3 participants
@fingolfin @lgoettgens @ThomasBreuer